[Bug 2244402] Review Request: python-ebcdic - Additional EBCDIC codecs for data exchange with legacy system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2244402



--- Comment #2 from Sandro <gui1ty@xxxxxxxxxxxxx> ---
Thank you for the review.

Regarding your comment:

Technically, calling `ant test` is a preparation for the build that follows.
So, I feel that %prep is the right step in the build process to do so. On the
other hand, I haven't looked into or tried to understand what the script does
under the hood. I simply followed the instructions given. I know it extracts
codecs from Java and prepares them for use in Python.

However, it appears that I can be more specific and call `ant ebcdic`, which
will only generate the codecs. It gets rid of the warnings and I can drop the
BR on python3-pycodestyle.

Spec URL:
https://download.copr.fedorainfracloud.org/results/gui1ty/extract-msg/fedora-rawhide-x86_64/06532732-python-ebcdic/python-ebcdic.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/gui1ty/extract-msg/fedora-rawhide-x86_64/06532732-python-ebcdic/python-ebcdic-1.1.1-3.fc40.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244402

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244402%23c2
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux