https://bugzilla.redhat.com/show_bug.cgi?id=2243260 Pavol Zacik <pzacik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pzacik@xxxxxxxxxx --- Comment #5 from Pavol Zacik <pzacik@xxxxxxxxxx> --- Mind that I'm not yet sponsored, so I won't be able to approve yet. Since this is a more complex request, I also haven't assigned myself to it, so others can see it open. Some comments: - Have you tried building mesa-demos with the newest version? The glvnd patch has already been included upstream since 1.0.6. [1] so it would be nicer to ship the most recent version without the downstream patch. There have also been very few commits since 1.0.4, and they do not seem very breaking to me, judging by their commit messages. - The usage of Conflicts seems in line with guidelines to me. - I would use the %{_mandir} macro instead of %{_datadir}/man. [1] https://gitlab.freedesktop.org/xorg/app/xdriinfo/-/commit/6273d9dacbf165331c21bcda5a8945c8931d87b8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2243260 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202243260%23c5 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
