[Bug 2242477] Review Request: python-APScheduler - Task scheduling library for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2242477



--- Comment #8 from mmassari@xxxxxxxxxx ---
Hi Nikola,

thanks for your review.

> I think you are supposed to move existing changelog entries from the spec file to a changelog file, what "rpmautospec generate-changelog" does is a preview of changelog generated from commit messages.

I wrote it in the wrong way, and I wasn't able to edit the message. I have used
'rpmautospec convert' to create a changelog file; the commit is not visible in
the srpm but I have it in a new commit locally.

> Why not?

I want to use packit with it and, if I am not mistaken, there are some open
issues for packit and the autorelease macro.

This is the latest build:

spec file:
https://download.copr.fedorainfracloud.org/results/mmassari/apscheduler/fedora-rawhide-x86_64/06519065-python-APScheduler/python-APScheduler.spec
srpm:
https://download.copr.fedorainfracloud.org/results/mmassari/apscheduler/fedora-rawhide-x86_64/06519065-python-APScheduler/python-APScheduler-3.10.4-1.fc40.src.rpm

- I have used %{pypi_source %{srcname}}
- I have removed: %{?python_provide:%python_provide python3-%{srcname}}
- And improved sed usage as you suggested

Maja


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2242477

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202242477%23c8
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux