https://bugzilla.redhat.com/show_bug.cgi?id=2242477 Nikola Forró <nforro@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nforro@xxxxxxxxxx --- Comment #7 from Nikola Forró <nforro@xxxxxxxxxx> --- (In reply to mmassari from comment #5) > As you suggested, I created a changelog file locally with the command: > rpmautospec generate-changelog python-APScheduler.spec I think you are supposed to move existing changelog entries from the spec file to a changelog file, what "rpmautospec generate-changelog" does is a preview of changelog generated from commit messages. > I prefer not to use the %autorelease macro, at least at the moment. Why not? A few notes to the spec file: > Source0: %{pypi_source} You should use "%{pypi_source %{srcname}}", omitting name is deprecated. > %{?python_provide:%python_provide python3-%{srcname}} I don't think this is necessary. > sed -i "s/ 'pytest-tornado5'/ 'pytest-tornado'/g" setup.py You can omit the whitespace, and you don't need "g". > sed -i "s/ 'pytest-cov',//g" setup.py You could use simpler "sed -i '/pytest-cov/d' setup.py". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2242477 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202242477%23c7 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
