https://bugzilla.redhat.com/show_bug.cgi?id=2243345 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Quick comments: 1. There are duplicate Summary and License tags in the package, this seems unintentional? The second ones are also likely subsumed by %description, having no effect (other than showing up in the package's %description, I guess). The location of the %files section is also unusual, it's usually the last section, i.e. between %install (or %check, if present) and %changelog. 2. You're setting `%bcond_without check` (i.e. package is built *with* check), but you removed the %check section (or did not include it). If there are unit tests that can be run during the build, please add back this snippet: %if %{with check} %check %cargo_test %endif 3. If you have used rust2rpm v25 to generate this spec file, please keep the "# Generated by rust2rpm 25" line at the top. We use it to track which spec files were generated from outdated templates. 4. It looks like the build failure is caused by missing BuildRequires for "pkgconfig(glib-2.0)" (or glib2-devel?). PS: Do you have a list of the crates are currently missing from Fedora, preventing this package from being built without vendored dependencies? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2243345 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202243345%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
