[Bug 2241003] Review Request: qnearbyshare - Nearby Share for Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2241003

Zephyr Lykos <fedora@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(benson_muite@emai
                   |                            |lplus.org)



--- Comment #8 from Zephyr Lykos <fedora@xxxxxxxxx> ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/mochaa/qnearbyshare/fedora-rawhide-x86_64/06502112-qnearbyshare/qnearbyshare.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/mochaa/qnearbyshare/fedora-rawhide-x86_64/06502112-qnearbyshare/qnearbyshare-0-1.20231007git9d56f79.fc40.src.rpm

> You may need to modify the service file so it is not automatically started on installation:

The D-Bus service is only activated on-demand (i.e. if something calls
com.vicr123.qnearbyshare)

> Is it possible to include the short git hash in the version:

We stick to Version: 0 because of
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_upstream_has_never_chosen_a_version
Git hash is handled in Release by autorelease & forge macros.

> directories without known owners:

Added dependency on dbus.

> requirement for libqnearbyshared-proto.so()(64bit)

Fixed in
https://github.com/vicr123/QNearbyShare/commit/14575fddcf8fc3f0c79c48356727ead963d56477

> qnearbyshare.x86_64: W: incoherent-version-in-changelog 0-1

rpmautospec only calculates release_number, without the extra tags.
Should be okay since a rel bump will occur when updating to a new commit.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2241003

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241003%23c8
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux