[Bug 2241003] Review Request: qnearbyshare - Nearby Share for Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2241003

Benson Muite <benson_muite@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(benson_muite@emai |
                   |lplus.org)                  |



--- Comment #7 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
You may need to modify the service file so it is not automatically started on
installation:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#activation_dbus
https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#why_dont_we

Is it possible to include the short git hash in the version:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

The review 
https://download.copr.fedorainfracloud.org/results/mochaa/qnearbyshare/fedora-rawhide-x86_64/06502112-qnearbyshare/fedora-review/review.txt
shows
a) directories without known owners:
Directories without known owners: /usr/share/dbus-1,
/usr/share/dbus-1/services
Maybe this is false, but may want to require one of the packages that owns
these directories.
b) requirement for libqnearbyshared-proto.so()(64bit)

c)
Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "qnearbyshare".
(none): E: there is no installed rpm "qnearbyshare-debugsource".
(none): E: there is no installed rpm "qnearbyshare-debuginfo".
There are no files to process nor additional arguments.
d)
qnearbyshare.x86_64: W: incoherent-version-in-changelog 0-1
['0-1.20231007git9d56f79.fc40', '0-1.20231007git9d56f79']


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2241003

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241003%23c7
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux