https://bugzilla.redhat.com/show_bug.cgi?id=2242449 --- Comment #3 from Milan Zamazal <mzamazal@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #2) > I see three issues immediately: Thank you for looking! > 1. You "addressed" one FIXME item, but not the other. The outputof > %cargo_license_summary is missing, and the resulting license tag must be > updated to match. OK, will do. > 2. Missing / broken debug package generation: > > > %global debug_package %{nil} > > strip %{buildroot}/%{_bindir}/* > > I don't know how you came up with this, but it is both unnecessary and > breaks the debuginfo stripping that automatically happens during RPM builds. > Remove both lines. Without the first line, I get the following error from rpmbuild: Processing files: rust-vhost-device-scmi-debugsource-0.1.0-1.fc40.x86_64 error: Empty %files file /root/rpmbuild/BUILD/vhost-device-scmi-0.1.0/debugsourcefiles.list RPM build errors: Empty %files file /root/rpmbuild/BUILD/vhost-device-scmi-0.1.0/debugsourcefiles.list The package doesn't contain any library, just a binary to run. Would you advise me how to deal with this error properly? > 3. Mangled %changelog: OK. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2242449 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202242449%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
