[Bug 2242449] Review Request: rust-vhost-device-scmi - Vhost-user SCMI backend device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2242449

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |decathorpe@xxxxxxxxx



--- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
I see three issues immediately:

1. You "addressed" one FIXME item, but not the other. The outputof
%cargo_license_summary is missing, and the resulting license tag must be
updated to match.

2. Missing / broken debug package generation:

> %global debug_package %{nil}
> strip %{buildroot}/%{_bindir}/*

I don't know how you came up with this, but it is both unnecessary and breaks
the debuginfo stripping that automatically happens during RPM builds. Remove
both lines.

3. Mangled %changelog:

Looks like tito does not support rpmautospec.

Remove these two lines, otherwise you will get a broken package:

> * Fri Oct 06 2023 Milan Zamazal <mzamazal@xxxxxxxxxx> 0.1.0-1
> - new package built with tito


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2242449

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202242449%23c2
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux