Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: themonospot -application that can be used to scan an avi file and extract some informations about audio and video data flow https://bugzilla.redhat.com/show_bug.cgi?id=427674 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2008-01-10 08:55 EST ------- Couple of issues: 1. minor, but unpleasant for reviewers: [wolfy@wolfy tmp]$ wget http://www.integrazioneweb.com/themonospot/packages/4-fedora/themonospot-0.6.5.spec --15:24:14-- http://www.integrazioneweb.com/themonospot/packages/4-fedora/themonospot-0.6.5.spec => `themonospot-0.6.5.spec' Resolving www.integrazioneweb.com... 151.13.66.154, 83.103.22.154 Connecting to www.integrazioneweb.com|151.13.66.154|:80... connected. HTTP request sent, awaiting response... 404 Not Found 15:24:25 ERROR 404: Not Found. 2. mock build problems: build fails with Processing files: themonospot-0.6.5-4 error: File not found: /var/tmp/themonospot-0.6.5-buildroot/usr/lib64/themonospot/languages/English.lf error: File not found: /var/tmp/themonospot-0.6.5-buildroot/usr/lib64/themonospot/languages/Italiano.lf Processing files: themonospot-debuginfo-0.6.5-4 Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/themonospot-0.6.5-buildroot error: Installed (but unpackaged) file(s) found: /usr/lib/themonospot/languages/English.lf /usr/lib/themonospot/languages/Italiano.lf /usr/lib/themonospot/themonospot-base.dll RPM build errors: File not found: /var/tmp/themonospot-0.6.5-buildroot/usr/lib64/themonospot/languages/English.lf File not found: /var/tmp/themonospot-0.6.5-buildroot/usr/lib64/themonospot/languages/Italiano.lf Installed (but unpackaged) file(s) found: /usr/lib/themonospot/languages/English.lf /usr/lib/themonospot/languages/Italiano.lf /usr/lib/themonospot/themonospot-base.dll 3. src.rpm issues: Needs work: * Source themonospot-0.6.5.tar.gz is different from upstream (and this usually is a show stoppper) * BuildRoot should be one of those listed in the wiki at Packaging/Guidelines#BuildRoot. The difference is minor compared to an accepted one, so please change it. * Specfile should be in the format %{name}.spec (see Packaging/ReviewGuidelines) Incidentally, are you already sponsored? I could not find you in FAS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review