Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: procps https://bugzilla.redhat.com/show_bug.cgi?id=226319 bugs.michael@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |bugs.michael@xxxxxxx Flag| |fedora-review+ ------- Additional Comments From bugs.michael@xxxxxxx 2008-01-10 08:35 EST ------- * The files in the source tarball use the LGPLv2+ not just the GPLv2+. * There's no reason why the %post scriptlet is not simply %post -p /sbin/ldconfig * From the build.log: /usr/bin/strip: unable to copy file '/home/qa/tmp/rpm/tmp/procps-3.2.7-17.fc8-root-qa/lib/libproc-3.2.7.so' reason: Permission denied That is because the lib is installed u-w and only later gets attr(0755,...). Easy to fix at end of %install section. * When you use "install" in the spec or modify the install options, prefer "install -p ..." to preserve file timestamps. Users appreciate it when the age of files in packages can be seen, and e.g. documentation from several years ago does not get a fresh timestamp as if it were new. This is easy to fix in the make install line. * All these can be fixed in CVS. Hence: APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review