https://bugzilla.redhat.com/show_bug.cgi?id=2235768 Jonathan S. <js-fedora@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(benson_muite@emai | |lplus.org) --- Comment #7 from Jonathan S. <js-fedora@xxxxxx> --- > The license files need to be installed whenever any of the libraries and binaries are installed. > What you have done is technically fine, just a suggestion that might minimize clutter. In that case, I think it's cleaner this way, as this doesn't break ls `/usr/share/licenses/$package` to see the license. > it seems that the Fedora compilation flags are not picked up in the generated buildsys.mk. Is it possible to add these? Ah, this seems to be because it sets CFLAGS and CXXFLAGS, but not OBJCFLAGS. I've set OBJCFLAGS to CFLAGS for now, but really, that's a hack. I think Fedora should also set OBJCFLAGS for builds. > libobjfw-devel.x86_64: E: rpath-in-buildconfig /usr/bin/objfw-config lines 69 This should be ignored. It's a shellscript that can emit flags for using rpath. It isn't used by itself, since --disable-rpath is passed to configure. > ofhash.x86_64: W: position-independent-executable-suggested /usr/bin/ofhash > ofdns.x86_64: W: position-independent-executable-suggested /usr/bin/ofdns > ofhttp.x86_64: W: position-independent-executable-suggested /usr/bin/ofhttp > libobjfw-devel.x86_64: W: position-independent-executable-suggested /usr/bin/objfw-new > ofarc.x86_64: W: position-independent-executable-suggested /usr/bin/ofarc This happens even when the flags are picked up. Looking at the flags passed by Fedora, there is nothing in CFLAGS or LDFLAGS for PIE. Shouldn't Fedora add the flags for PIE to those if it wants PIE? New spec file: https://nil.im/objfw.spec New SRPM: https://nil.im/objfw-1.0-1.fc40.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2235768 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202235768%23c7 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
