https://bugzilla.redhat.com/show_bug.cgi?id=2235768 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) | --- Comment #6 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- The license files need to be installed whenever any of the libraries and binaries are installed. What you have done is technically fine, just a suggestion that might minimize clutter. The current spec file still pulls in openssl 1.1 to get 3 instead of BuildRequires: pkgconfig(openssl) Use BuildRequires: openssl-devel An example spec file is at: https://download.copr.fedorainfracloud.org/results/fed500/objfw/fedora-rawhide-x86_64/06389821-objfw/objfw.spec >From that build log: https://download.copr.fedorainfracloud.org/results/fed500/objfw/fedora-rawhide-x86_64/06389821-objfw/builder-live.log.gz it seems that the Fedora compilation flags are not picked up in the generated buildsys.mk. Is it possible to add these? Finally, from rpmlint messages: libobjfw-devel.x86_64: E: rpath-in-buildconfig /usr/bin/objfw-config lines 69 ofhash.x86_64: W: position-independent-executable-suggested /usr/bin/ofhash ofdns.x86_64: W: position-independent-executable-suggested /usr/bin/ofdns ofhttp.x86_64: W: position-independent-executable-suggested /usr/bin/ofhttp libobjfw-devel.x86_64: W: position-independent-executable-suggested /usr/bin/objfw-new ofarc.x86_64: W: position-independent-executable-suggested /usr/bin/ofarc $ rpmlint -e position-independent-executable-suggested position-independent-executable-suggested: This executable should be position independent (all binaries should). Check that it is built with -fPIE/-fpie in compiler flags and -pie in linker flags. $ rpmlint -e rpath-in-buildconfig rpath-in-buildconfig: This build configuration file contains rpaths which will be introduced into dependent packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2235768 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202235768%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
