https://bugzilla.redhat.com/show_bug.cgi?id=2233796 --- Comment #3 from Kalev Lember <klember@xxxxxxxxxx> --- Oh nice, thanks! Makes a lot of sense for me to do it like that. The only thing I'd change there is that in the patch, the hunk that changes build.rs I'd keep the existing indentation for the bindgen code path - basically keep the {} that comes after #[cfg(feature = "use-bindgen")] intact, so that the indentation doesn't change. I think doing it like that makes it easier to see what's changed since this is, I assume, going to live as a downstream patch forever. Or do you think there's a way to upstream it? Maybe we can create the repo, I push my initial packaging and then you can change it to use bindgen unconditionally? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2233796 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202233796%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
