https://bugzilla.redhat.com/show_bug.cgi?id=2233796 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Since the crate already supported regenerating the Rust bindings at build-time, it was relatively straightforward to do that unconditionally (this is also preferred by the Packaging Guidelines). This also solves the test failure on i686: https://koji.fedoraproject.org/koji/taskinfo?taskID=105185550 For this, the bindgen build-dependency needs to be non-optional, and small changes to build.rs and src/lib.rs are necessary. I've posted an SRPM with a modified spec + patches online, if you want to take a look: https://decathorpe.fedorapeople.org/rust-libheif-sys-1.16.1-1.fc38.src.rpm Essentially, what I did was patching out code paths for non-bindgen use, and made those for bindgen use unconditional (both in build.rs and src/lib.rs, and src/bindings.rs - the pre-generated bindings and tests - could be removed entirely, since it's then unused). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2233796 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202233796%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
