https://bugzilla.redhat.com/show_bug.cgi?id=2152347 --- Comment #10 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you, Benson. (In reply to Benson Muite from comment #9) > b) Is it possible to add below or equivalent to the spec file to ensure > directory ownership > %dir %{_datadir}/SMuFL > %dir %{_datadir}/SMuFL/Fonts > %dir %{_datadir}/SMuFL/Fonts/'Finale Ash' > %dir %{_datadir}/SMuFL/Fonts/'Finale Ash Text' > %dir %{_datadir}/SMuFL/Fonts/'Finale Broadway' > %dir %{_datadir}/SMuFL/Fonts/'Finale Broadway Text' > %dir %{_datadir}/SMuFL/Fonts/'Finale Broadway Legacy Text' > %dir %{_datadir}/SMuFL/Fonts/'Finale Engraver' > %dir %{_datadir}/SMuFL/Fonts/'Finale Jazz Text' > %dir %{_datadir}/SMuFL/Fonts/'Finale Jazz Text Lowercase' > %dir %{_datadir}/SMuFL/Fonts/'Finale Legacy' > %dir %{_datadir}/SMuFL/Fonts/'Finale Ash' > %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro' > %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text' > %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text Bold' > %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text Bold Italic' > %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text Italic' Oops, yes, those were supposed to be in there. I have added the first two to each subpackage. The rest are not needed as the same path without %dir is already present. > c) Should there be a license declaration > %global fontlicenses OFL.txt > Font license is not installed with any of the font files Yes, I forgot the -l argument to %fontinstall. It's a good thing you are reviewing this package to catch my mistakes. :-) > d) The msi package includes some additional TTF fonts. Assume these are not > needed? Yes, I think those are all either "legacy" fonts that are no longer supported, or duplicates of the OpenType fonts in these packages. In any case, MuseScore doesn't need any of them. New URLs: Spec URL: https://jjames.fedorapeople.org/makemusic-finale-fonts/makemusic-finale-fonts.spec SRPM URL: https://jjames.fedorapeople.org/makemusic-finale-fonts/makemusic-finale-fonts-0-1.fc40.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2152347 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202152347%23c10 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
