https://bugzilla.redhat.com/show_bug.cgi?id=2152347 --- Comment #9 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [!]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/SMuFL [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/SMuFL/Fonts, /usr/share/SMuFL [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). fonts: [!]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined [!]: Run ttname on all fonts in package. Note: Cannot find ttname command, install ttname package to make a comprehensive font review. See: url: undefined Rpmlint ------- Checking: finale-ash-fonts-1.7-1.fc39.noarch.rpm finale-ash-text-fonts-1.3-1.fc39.noarch.rpm finale-broadway-fonts-1.4-1.fc39.noarch.rpm finale-broadway-legacy-text-fonts-1.1-1.fc39.noarch.rpm finale-broadway-text-fonts-1.1-1.fc39.noarch.rpm finale-engraver-fonts-1.4-1.fc39.noarch.rpm finale-jazz-fonts-1.9-1.fc39.noarch.rpm finale-jazz-text-fonts-1.3-1.fc39.noarch.rpm finale-jazz-text-lowercase-fonts-1.4-1.fc39.noarch.rpm finale-legacy-fonts-1.6-1.fc39.noarch.rpm finale-lyrics-fonts-2.3-1.fc39.noarch.rpm finale-maestro-fonts-2.7-1.fc39.noarch.rpm finale-maestro-text-fonts-1.6-1.fc39.noarch.rpm makemusic-finale-fonts-0-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp10chakth')] checks: 31, packages: 14 finale-ash-fonts.noarch: W: no-documentation finale-ash-text-fonts.noarch: W: no-documentation finale-broadway-fonts.noarch: W: no-documentation finale-broadway-legacy-text-fonts.noarch: W: no-documentation finale-broadway-text-fonts.noarch: W: no-documentation finale-engraver-fonts.noarch: W: no-documentation finale-jazz-fonts.noarch: W: no-documentation finale-jazz-text-fonts.noarch: W: no-documentation finale-jazz-text-lowercase-fonts.noarch: W: no-documentation finale-legacy-fonts.noarch: W: no-documentation finale-lyrics-fonts.noarch: W: no-documentation finale-maestro-fonts.noarch: W: no-documentation finale-maestro-text-fonts.noarch: W: no-documentation 14 packages and 0 specfiles checked; 0 errors, 13 warnings, 0 badness; has taken 3.6 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 13 finale-maestro-fonts.noarch: W: no-documentation finale-jazz-text-lowercase-fonts.noarch: W: no-documentation finale-broadway-legacy-text-fonts.noarch: W: no-documentation finale-jazz-text-fonts.noarch: W: no-documentation finale-lyrics-fonts.noarch: W: no-documentation finale-ash-text-fonts.noarch: W: no-documentation finale-broadway-fonts.noarch: W: no-documentation finale-maestro-text-fonts.noarch: W: no-documentation finale-legacy-fonts.noarch: W: no-documentation finale-engraver-fonts.noarch: W: no-documentation finale-ash-fonts.noarch: W: no-documentation finale-jazz-fonts.noarch: W: no-documentation finale-broadway-text-fonts.noarch: W: no-documentation 13 packages and 0 specfiles checked; 0 errors, 13 warnings, 0 badness; has taken 0.8 s Source checksums ---------------- https://makemusic.zendesk.com/hc/en-us/article_attachments/4402710909975/OFL.txt : CHECKSUM(SHA256) this package : ddb4d751552bb20edf19e990587339e0d19206d585c8bf4acd3e6a230658d951 CHECKSUM(SHA256) upstream package : ddb4d751552bb20edf19e990587339e0d19206d585c8bf4acd3e6a230658d951 https://makemusic.zendesk.com/hc/en-us/article_attachments/4586784089367/MMFonts.msi : CHECKSUM(SHA256) this package : 8f00e2159fc1346325f1d1f98be89234a650b5d10e141831c581029cc57613d0 CHECKSUM(SHA256) upstream package : 8f00e2159fc1346325f1d1f98be89234a650b5d10e141831c581029cc57613d0 Requires -------- finale-ash-fonts (rpmlib, GLIBC filtered): config(finale-ash-fonts) fontpackages-filesystem finale-ash-text-fonts (rpmlib, GLIBC filtered): config(finale-ash-text-fonts) fontpackages-filesystem finale-broadway-fonts (rpmlib, GLIBC filtered): config(finale-broadway-fonts) fontpackages-filesystem finale-broadway-legacy-text-fonts (rpmlib, GLIBC filtered): config(finale-broadway-legacy-text-fonts) fontpackages-filesystem finale-broadway-text-fonts (rpmlib, GLIBC filtered): config(finale-broadway-text-fonts) fontpackages-filesystem finale-engraver-fonts (rpmlib, GLIBC filtered): config(finale-engraver-fonts) fontpackages-filesystem finale-jazz-fonts (rpmlib, GLIBC filtered): config(finale-jazz-fonts) fontpackages-filesystem finale-jazz-text-fonts (rpmlib, GLIBC filtered): config(finale-jazz-text-fonts) fontpackages-filesystem finale-jazz-text-lowercase-fonts (rpmlib, GLIBC filtered): config(finale-jazz-text-lowercase-fonts) fontpackages-filesystem finale-legacy-fonts (rpmlib, GLIBC filtered): config(finale-legacy-fonts) fontpackages-filesystem finale-lyrics-fonts (rpmlib, GLIBC filtered): config(finale-lyrics-fonts) fontpackages-filesystem finale-maestro-fonts (rpmlib, GLIBC filtered): config(finale-maestro-fonts) fontpackages-filesystem finale-maestro-text-fonts (rpmlib, GLIBC filtered): config(finale-maestro-text-fonts) fontpackages-filesystem Provides -------- finale-ash-fonts: config(finale-ash-fonts) finale-ash-fonts font(finaleash) metainfo() metainfo(com.makemusic.finale-ash-fonts.metainfo.xml) finale-ash-text-fonts: config(finale-ash-text-fonts) finale-ash-text-fonts font(finaleashtext) metainfo() metainfo(com.makemusic.finale-ash-text-fonts.metainfo.xml) finale-broadway-fonts: config(finale-broadway-fonts) finale-broadway-fonts font(finalebroadway) metainfo() metainfo(com.makemusic.finale-broadway-fonts.metainfo.xml) finale-broadway-legacy-text-fonts: config(finale-broadway-legacy-text-fonts) finale-broadway-legacy-text-fonts font(finalebroadwaylegacytext) metainfo() metainfo(com.makemusic.finale-broadway-legacy-text-fonts.metainfo.xml) finale-broadway-text-fonts: config(finale-broadway-text-fonts) finale-broadway-text-fonts font(finalebroadwaytext) metainfo() metainfo(com.makemusic.finale-broadway-text-fonts.metainfo.xml) finale-engraver-fonts: config(finale-engraver-fonts) finale-engraver-fonts font(finaleengraver) metainfo() metainfo(com.makemusic.finale-engraver-fonts.metainfo.xml) finale-jazz-fonts: config(finale-jazz-fonts) finale-jazz-fonts font(finalejazz) metainfo() metainfo(com.makemusic.finale-jazz-fonts.metainfo.xml) finale-jazz-text-fonts: config(finale-jazz-text-fonts) finale-jazz-text-fonts font(finalejazztext) metainfo() metainfo(com.makemusic.finale-jazz-text-fonts.metainfo.xml) finale-jazz-text-lowercase-fonts: config(finale-jazz-text-lowercase-fonts) finale-jazz-text-lowercase-fonts font(finalejazztextlowercase) metainfo() metainfo(com.makemusic.finale-jazz-text-lowercase-fonts.metainfo.xml) finale-legacy-fonts: config(finale-legacy-fonts) finale-legacy-fonts font(finalelegacy) metainfo() metainfo(com.makemusic.finale-legacy-fonts.metainfo.xml) finale-lyrics-fonts: config(finale-lyrics-fonts) finale-lyrics-fonts font(finalelyrics) metainfo() metainfo(com.makemusic.finale-lyrics-fonts.metainfo.xml) finale-maestro-fonts: config(finale-maestro-fonts) finale-maestro-fonts font(finalemaestro) metainfo() metainfo(com.makemusic.finale-maestro-fonts.metainfo.xml) finale-maestro-text-fonts: config(finale-maestro-text-fonts) finale-maestro-text-fonts font(finalemaestrotext) metainfo() metainfo(com.makemusic.finale-maestro-text-fonts.metainfo.xml) Diff spec file in url and in SRPM --------------------------------- --- /home/benson/Projects/FedoraPackaging/reviews/makemusic-finale-fonts/2152347-makemusic-finale-fonts/srpm/makemusic-finale-fonts.spec 2023-06-19 15:22:23.395593242 +0300 +++ /home/benson/Projects/FedoraPackaging/reviews/makemusic-finale-fonts/2152347-makemusic-finale-fonts/srpm-unpacked/makemusic-finale-fonts.spec 2023-03-16 03:00:00.000000000 +0300 @@ -252,6 +252,8 @@ %setup -q -c -T msiextract %{SOURCE0} -cp -p %{SOURCE1} . -%linuxtext -n OFL.txt + +# Fix end of line encodings +sed 's/\r//' %{SOURCE1} > OFL.txt +touch -r %{SOURCE1} OFL.txt %build Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2152347 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, fonts Disabled plugins: Haskell, C/C++, Java, PHP, Perl, Ruby, R, Python, SugarActivity, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Due to packaging as MSI timestamps cannot be preserved b) Is it possible to add below or equivalent to the spec file to ensure directory ownership %dir %{_datadir}/SMuFL %dir %{_datadir}/SMuFL/Fonts %dir %{_datadir}/SMuFL/Fonts/'Finale Ash' %dir %{_datadir}/SMuFL/Fonts/'Finale Ash Text' %dir %{_datadir}/SMuFL/Fonts/'Finale Broadway' %dir %{_datadir}/SMuFL/Fonts/'Finale Broadway Text' %dir %{_datadir}/SMuFL/Fonts/'Finale Broadway Legacy Text' %dir %{_datadir}/SMuFL/Fonts/'Finale Engraver' %dir %{_datadir}/SMuFL/Fonts/'Finale Jazz Text' %dir %{_datadir}/SMuFL/Fonts/'Finale Jazz Text Lowercase' %dir %{_datadir}/SMuFL/Fonts/'Finale Legacy' %dir %{_datadir}/SMuFL/Fonts/'Finale Ash' %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro' %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text' %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text Bold' %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text Bold Italic' %dir %{_datadir}/SMuFL/Fonts/'Finale Maestro Text Italic' c) Should there be a license declaration %global fontlicenses OFL.txt Font license is not installed with any of the font files d) The msi package includes some additional TTF fonts. Assume these are not needed? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2152347 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202152347%23c9 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
