https://bugzilla.redhat.com/show_bug.cgi?id=2230729 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Kalev Lember from comment #6) > OK, so I haven't heard anything back from upstream yet, but I think we can > still move forward with this. For s390x, I went ahead and just disabled the > tests - the failures still need investigating, but it shouldn't block the > packaging work for other arches. > > As for the test-data directory, I believe I found the source for the icons > after some googling - it appears to be > https://www.svgrepo.com/svg/442121/document-send-symbolic and licensed under > CC-BY (which is a Fedora allowed license). So I think we don't need to > exclude these files from the tarball, but I went ahead and removed from the > distributed files that end up in the rpm just in case. This also saves us > from having to list them as a downstream-modification in the license tag. > > What do you think, does it make sense? Thanks for investigating! Yes, I think this is correct. If the files are under a license that allows redistribution, then having them in the SRPM is fine. And since they're not shipped, they don't affect the License tag of the package. As for the failing tests on big-endian, skipping tests on s390x is a good solution for now. Not building the package on s390x would have unpleasant knock-on effects in dependent packages, as you noted. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Three minor things that don't block approval: - include the link to the upstream issue for the s390x failures above the "%ifnarch s390x" - include the link to the upstream issue for the test-data license above the patch - include the link to the upstream issue for the missing license file above Source1 Having the links to the issues in the spec file alongside the code that refers to them is really nice when you're looking at packages that are maintained by others (or that you have last touched yourself months or years ago). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2230729 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202230729%23c7 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
