https://bugzilla.redhat.com/show_bug.cgi?id=2230729 --- Comment #6 from Kalev Lember <klember@xxxxxxxxxx> --- OK, so I haven't heard anything back from upstream yet, but I think we can still move forward with this. For s390x, I went ahead and just disabled the tests - the failures still need investigating, but it shouldn't block the packaging work for other arches. As for the test-data directory, I believe I found the source for the icons after some googling - it appears to be https://www.svgrepo.com/svg/442121/document-send-symbolic and licensed under CC-BY (which is a Fedora allowed license). So I think we don't need to exclude these files from the tarball, but I went ahead and removed from the distributed files that end up in the rpm just in case. This also saves us from having to list them as a downstream-modification in the license tag. Here's my comment in my local git commit for the package: --- Exclude test-data directory that has unclear licensing (rhbz#2230729) As per discussion in https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2230729#c3 The svg icons in test-data directory appear to be licensed under CC-BY, but still waiting for a confirmation from gvdb-rs upstream. Since they appear to be free software and under fedora approved license, we don't need to respin the tarball, but out of caution, exclude them from distributed files for now. This also saves us from having to manually update the license tag. Likely source for the icons: https://www.svgrepo.com/svg/442121/document-send-symbolic Upstream issue: https://github.com/felinira/gvdb-rs/issues/11 --- What do you think, does it make sense? Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=105087553 Spec URL: https://kalev.fedorapeople.org/rust-gvdb.spec SRPM URL: https://kalev.fedorapeople.org/rust-gvdb-0.5.1-3.fc40.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2230729 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202230729%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
