[Bug 2203715] Review Request: gmult - Multiplication Puzzle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2203715

Kalev Lember <klember@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |klember@xxxxxxxxxx



--- Comment #1 from Kalev Lember <klember@xxxxxxxxxx> ---
Taking for review.

Looks like nice and clean packaging, but it doesn't seem to build:

$ mock -r fedora-rawhide-x86_64 ./gmult-12.0-1.fc39.src.rpm

[snip]

../gmult/DigitBox.vala:72.5-72.32: warning: `Gtk.Widget.translate_coordinates'
has been deprecated since 4.12
   72 |     window.translate_coordinates(this, 0, 0, out x_offset, out
y_offset);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~                                        
../gmult/main.vala:112.5-112.27: warning: `Gtk.CssProvider.load_from_data' has
been deprecated since 4.12
  112 |     provider.load_from_data(css.data);
      |     ^~~~~~~~~~~~~~~~~~~~~~~           
../gmult/main.vala:112.29-112.36: error: Argument 1: Cannot convert from
`unowned uint8[]' to `unowned string'
  112 |     provider.load_from_data(css.data);
      |                             ^~~~~~~~  
../gmult/main.vala:112.5-112.37: error: 1 missing arguments for `void
Gtk.CssProvider.load_from_data (string, ssize_t)'
  112 |     provider.load_from_data(css.data);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
Compilation failed: 2 error(s), 2 warning(s)


Any ideas? Looks like something changed in vala?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2203715

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202203715%23c1
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux