https://bugzilla.redhat.com/show_bug.cgi?id=2231209 --- Comment #7 from Spike <SpikeFedora@xxxxxxxxx> --- Thanks again, Petr. I wasn't aware that %{_sourcedir} also should be avoided when the package is not using files itemized as Source# files. Updated spec and SRPM file can be found here: https://spike.fedorapeople.org/openvpn-otp/openvpn-otp.spec https://spike.fedorapeople.org/openvpn-otp/openvpn-otp-1.0%5e20230731git47f8ccf-1.fc38.src.rpm (In reply to Petr Pisar from comment #6) > FIX: Extract a copyright notice from src/base64.c or src/base64.h and > package it a binary package. APSL-2.0 license does not only require > distributing the license text, but also a copyright notice along the output > object files. It is the text between "@APPLE_LICENSE_HEADER_START@" and > "@APPLE_LICENSE_HEADER_END@" lines. Done. > FIX: Use "install -m 0644 %{SOURCE1} %{SOURCE2} %{SOURCE3} ." instead of "cp > %{_sourcedir}/$license .". The %{SOURCEN} macros avoid using %{_sourcedir}. > The "install -m" prevents from mangling a mode of file in case of an > unexpected umask. Done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2231209 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202231209%23c7 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
