https://bugzilla.redhat.com/show_bug.cgi?id=2231209 --- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> --- Thanks for the fixes. FIX: Extract a copyright notice from src/base64.c or src/base64.h and package it a binary package. APSL-2.0 license does not only require distributing the license text, but also a copyright notice along the output object files. It is the text between "@APPLE_LICENSE_HEADER_START@" and "@APPLE_LICENSE_HEADER_END@" lines. You can use this sed script in %prep or %build section to do it: $ sed -n -e '/@APPLE_LICENSE_HEADER_START@/,/@APPLE_LICENSE_HEADER_END@/p' < src/base64.c > base64_copyright Then don't forget to build-require "sed". $ rpmlint openvpn-otp.spec ../SRPMS/openvpn-otp-1.0^20230731git47f8ccf-1.fc40.src.rpm ../RPMS/x86_64/openvpn-otp-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 5 openvpn-otp.spec:36: E: use-of-RPM_SOURCE_DIR openvpn-otp.spec:36: E: use-of-RPM_SOURCE_DIR ========= 4 packages and 1 specfiles checked; 2 errors, 0 warnings, 2 badness; has taken 0.3 s ======== FIX: Use "install -m 0644 %{SOURCE1} %{SOURCE2} %{SOURCE3} ." instead of "cp %{_sourcedir}/$license .". The %{SOURCEN} macros avoid using %{_sourcedir}. The "install -m" prevents from mangling a mode of file in case of an unexpected umask. $ rpm -qlvp ../RPMS/x86_64/openvpn-otp-1.0^20230731git47f8ccf-1.fc40.x86_64.rpm drwxr-xr-x 2 root root 0 Aug 11 02:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Aug 11 02:00 /usr/lib/.build-id/16 lrwxrwxrwx 1 root root 52 Aug 11 02:00 /usr/lib/.build-id/16/094d59d0ada1d7755e2e5f39103fc8674f0d20 -> ../../../../usr/lib64/openvpn/plugins/openvpn-otp.so -rwxr-xr-x 1 root root 32504 Aug 11 02:00 /usr/lib64/openvpn/plugins/openvpn-otp.so drwxr-xr-x 2 root root 0 Aug 11 02:00 /usr/share/doc/openvpn-otp -rw-r--r-- 1 root root 13918 Aug 7 2021 /usr/share/doc/openvpn-otp/README.md drwxr-xr-x 2 root root 0 Aug 11 02:00 /usr/share/licenses/openvpn-otp -rw-r--r-- 1 root root 20285 Aug 11 02:00 /usr/share/licenses/openvpn-otp/APSL-2.0.txt -rw-r--r-- 1 root root 2507 Aug 11 02:00 /usr/share/licenses/openvpn-otp/Apache-1.0.txt -rw-r--r-- 1 root root 10280 Aug 11 02:00 /usr/share/licenses/openvpn-otp/Apache-2.0.txt -rw-r--r-- 1 root root 35121 Aug 7 2021 /usr/share/licenses/openvpn-otp/LICENSE File layout and permissions are Ok. The package builds in Fedora Rawhide <https://koji.fedoraproject.org/koji/taskinfo?taskID=104872280>. Ok. Please correct the two "FIX" items, an provide an updated spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2231209 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202231209%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
