https://bugzilla.redhat.com/show_bug.cgi?id=2224783 --- Comment #4 from Mattia Verga <mattia.verga@xxxxxxxxx> --- (In reply to Felix Wang from comment #3) > I only see an issue: static library should be avoided as possible. The > remaining things LGTM. This is a header only library, so adheres to https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries BTW, if you're willing to make a formal review, you should set the ticket status to ASSIGNED and set yourself as the assignee. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2224783 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202224783%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
