https://bugzilla.redhat.com/show_bug.cgi?id=2193261 Peter Oliver <mavit@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mavit@xxxxxxxxx.u | |k) | --- Comment #2 from Peter Oliver <mavit@xxxxxxxxxxxx> --- (In reply to Marc-Andre Lureau from comment #1) > I like the short generic spec! Given that we are likely going to see dozens > of those, we should set a good example. If this works out okay, I intend to turn it into a template: https://pagure.io/fork/mavit/rpmdevtools/diff/main..tree-sitter > Things to look after according to fedora-review: > libtree-sitter-java.x86_64: E: shared-library-without-dependency-information > /usr/lib64/libtree-sitter-java.so.0.0 I don't know enough about C development to answer this, but I think this is somehow expected because this isn't a stand-alone library, but rather something you have to load with libtree-sitter. Perhaps we shouldn't be installing it directly into %{_libdir}? > libtree-sitter-java.x86_64: E: explicit-lib-dependency libtree-sitter I think we need the explicit dependency here, because of the above: libtree-sitter-java.so doesn't have a dependency on libtree-sitter.so even though it requires it. > libtree-sitter-java-devel.x86_64: E: double-slash-in-pkgconfig-path > /usr/lib64/pkgconfig/tree-sitter-java.pc URL: > https///github.com/tree-sitter/tree-sitter-java This is an bug in the upstream Makefile, which assumes that all Git URLs look like git@xxxxxxxxxx:tree-sitter/tree-sitter-java.git rather than https://github.com/tree-sitter/tree-sitter-java.git: ifeq (, $(PARSER_URL)) PARSER_URL := $(subst :,/,$(PARSER_REPO_URL)) PARSER_URL := $(subst git@,https://,$(PARSER_URL)) PARSER_URL := $(subst .git,,$(PARSER_URL)) endif I'll prepare a patch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2193261 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202193261%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
