https://bugzilla.redhat.com/show_bug.cgi?id=2224629 --- Comment #14 from Tyler Fanelli <tfanelli@xxxxxxxxxx> --- > I couldn't even untar the file with "tar -xzvf" (not valid gzip?) or gnome's > archive manager (it just crashed) Hm, I must have done something wrong there when tar'ing. > so it was very suspicious ;) I don't blame you :) > The package looks good to me now, I only have three non-blocking comments: > > 1. There's only an rpmlint warning that might be interesting for upstream: > > snphost.x86_64: W: unused-direct-shlib-dependency /usr/bin/snphost > /lib64/libm.so.6 > > Not sure if linking with libm is still necessary, as far as I know, at least > recent Fedora versions merged libm into libc again? How would I check which package is requiring this import? > > 2. Also please add a comment why you're doing "ExcludeArch: x86_64" before > you import the package. > Something like "this is only supported on AMD hardware" would be enough. Noted, will do. > > 3. It looks like upstream project has an asdiidoc file that can be built > into a manpage? > If you add a BR for asciidoctor (or something like it) and build the man > page in %build, you could install it alongside the binary. Users might find > that helpful. > Agreed, will do. > Side note: Please take care to import the original / "unprocessed" spec file > wrt/ rpmautospec (i.e. it should have "Release: %autorelease", "%changelog\n > %autochangelog"). If you want to avoid this problem (different spec file > inside / outside SRPM), I recommend using plain "rpmbuild -bs" to generate > the SRPM file instead of "fedpkg srpm". Noted. Thanks for pointing that out. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2224629 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202224629%23c14 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
