https://bugzilla.redhat.com/show_bug.cgi?id=2224629 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #13 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > Yes, I was building from the tagged release from GitHub rather than crates.io. I've fixed this issue here: That could explain it, thanks for using the correct source. I couldn't even untar the file with "tar -xzvf" (not valid gzip?) or gnome's archive manager (it just crashed) so it was very suspicious ;) The package looks good to me now, I only have three non-blocking comments: 1. There's only an rpmlint warning that might be interesting for upstream: snphost.x86_64: W: unused-direct-shlib-dependency /usr/bin/snphost /lib64/libm.so.6 Not sure if linking with libm is still necessary, as far as I know, at least recent Fedora versions merged libm into libc again? 2. Also please add a comment why you're doing "ExcludeArch: x86_64" before you import the package. Something like "this is only supported on AMD hardware" would be enough. 3. It looks like upstream project has an asdiidoc file that can be built into a manpage? If you add a BR for asciidoctor (or something like it) and build the man page in %build, you could install it alongside the binary. Users might find that helpful. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide ? test suite is run and all unit tests pass (there are no tests 😢) - latest version of the crate is packaged - license matches upstream specification (Apache-2.0) and is acceptable for Fedora - license file is included with %license in %files - subpackage that includes statically linked binary has appropriate license tag - license breakdown is documented (automatically generated by %cargo_license) - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Side note: Please take care to import the original / "unprocessed" spec file wrt/ rpmautospec (i.e. it should have "Release: %autorelease", "%changelog\n %autochangelog"). If you want to avoid this problem (different spec file inside / outside SRPM), I recommend using plain "rpmbuild -bs" to generate the SRPM file instead of "fedpkg srpm". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2224629 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202224629%23c13 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
