https://bugzilla.redhat.com/show_bug.cgi?id=2227475 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks, looks good to me now (with one exception, noted below). This package is even running tests, which the librsvg2 package apparently doesn't 😅 === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (LGPL-2.1-or-later) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === This crate tarball contains a large amount of stuff that's unused and should be dropped. For example, there's a lot of data files (graphics and fonts with separate licenses, etc.) that should be excluded since autotools, docs, CI files, etc. are all unwanted in a pure-Rust library package. Adding something like this to the [package] table in Cargo.toml should work (with "%doc %{crate_instdir}/rsvg-convert.rst" removed from the file list): """ exclude = [ "/benchmarks/", "/ci/", "/devel-docs/", "/doc/", "/include", "/m4/", "/tests/", "/tools/", "/win32", "/acinclude.m4", "/appveyor.yml", "/autogen.sh", "/configure.ac", "/deny.toml", "/example.svg", "/glib-tap.mk", "/INSTALL", "/librsvg.doap", "/librsvg.pc.in", "/librsvg-zip.in", "/Makefile.am", "/Rsvg-2.0.metadata", "/Rsvg-2.0-custom.vala", "/rsvg-convert.rst", "/rsvg-c-srcs.mk", "/tap-driver.sh", "/tap-test", ] """ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2227475 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202227475%23c7 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
