[Bug 2109838] Review Request: golang-github-oracle-oci-sdk-60 - Go SDK for Oracle Cloud Infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2109838

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review?
                   |                            |needinfo?(mark.e.fuller@gmx
                   |                            |.de)
           Doc Type|---                         |If docs needed, set a value
             Status|NEW                         |ASSIGNED
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #2 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
 - Update to 65.45.0

 - Update to SPDX licensing. Also it is dual licensed with UPL

 - Don't disable the entire check section

 - don't leave this if you are not packaging the library :

%files
%license LICENSE.txt NOTICE.txt
%doc example CHANGELOG.md CONTRIBUTING.md README.md THIRD_PARTY_LICENSES.txt
%doc THIRD_PARTY_LICENSES_DEV.txt

 - use latest go2rpm for you spec:

# Generated by go2rpm 1.9.0
%bcond_without check
%global debug_package %{nil}

# https://github.com/oracle/oci-go-sdk
%global goipath         github.com/oracle/oci-go-sdk/v65
Version:                65.45.0

%gometa -f

%global common_description %{expand:
Go SDK for Oracle Cloud Infrastructure.}

%global golicenses      LICENSE.txt NOTICE.txt
%global godocs          example CHANGELOG.md CONTRIBUTING.md README.md\\\
                        SECURITY.md

Name:           %{goname}
Release:        %autorelease
Summary:        Go SDK for Oracle Cloud Infrastructure

License:        Apache-2.0 OR UPL-1.0
URL:            %{gourl}
Source:         %{gosource}

%description %{common_description}

%gopkg

%prep
%goprep
%autopatch -p1

%generate_buildrequires
%go_generate_buildrequires

%install
%gopkginstall
%if %{with check}
%check
for test in "TestUploadFileMultiparts" \
            "TestUploadStreamMultiparts" \
            "TestUploadReqest_initDefaultValues" \
            "TestUploadFileReqest_initDefaultValues" \
            "TestUploadManager_UploadFile" \
            "TestUploadManager_UploadStream" \
; do
awk -i inplace '/^func.*'"$test"'\(/ { print; print "\tt.Skip(\"disabled
failing test\")"; next}1' $(grep -rl $test)
done
%gocheck
%endif

%gopkgfiles

%changelog
%autochangelog



Needinfo when you have fixed the issues.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2109838

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202109838%23c2
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux