https://bugzilla.redhat.com/show_bug.cgi?id=2221992 --- Comment #3 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxxx> --- (In reply to Mihai Patrascoiu from comment #2) > Hello, > > Please find below the output of the review. > I've flagged the following two items for more attention: > > [?]: Package contains no static executables. > [?]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in oidc- > agent-cli , oidc-agent-desktop , oidc-agent-libs , oidc-agent-devel > > Other than that, everything else looks good! > > Cheers, > Mihai Hi The binaries are all dynamically linked. The output from "file" says "dynamically linked": $ file usr/bin/* usr/bin/oidc-add: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=0390df2ab8c30a221e644a71dd4e574c495b04b9, for GNU/Linux 3.2.0, stripped usr/bin/oidc-agent: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=78993cf04ad343fedee5403d3a625bd66afa50b2, for GNU/Linux 3.2.0, stripped usr/bin/oidc-agent-service: Bourne-Again shell script, ASCII text executable usr/bin/oidc-gen: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=6ddf0886a89cac83c90484a876d2495c05a562d2, for GNU/Linux 3.2.0, stripped usr/bin/oidc-keychain: Bourne-Again shell script, ASCII text executable usr/bin/oidc-prompt: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=02d1ee78913e4cb3f15bc88cefc2d2303d8a1da3, for GNU/Linux 3.2.0, stripped usr/bin/oidc-token: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=6550338386206e81538e7e1212181986ff6770cc, for GNU/Linux 3.2.0, stripped The library is in the libs subpackage. The other subpackages Have fully qualified (version-release) requires on it: $ grep -E '(%package|%{name}-libs)' oidc-agent.spec %package cli Requires: %{name}-libs%{?_isa} = %version-%{release} %package desktop Requires: %{name}-libs%{?_isa} = %version-%{release} %package libs %package devel Requires: %{name}-libs%{?_isa} = %version-%{release} Mattias -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2221992 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202221992%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
