https://bugzilla.redhat.com/show_bug.cgi?id=2221992 Mihai Patrascoiu <mihai.patrascoiu@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mihai.patrascoiu@xxxxxxx Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mihai.patrascoiu@xxxxxxx Flags| |fedora-review? Doc Type|--- |If docs needed, set a value --- Comment #2 from Mihai Patrascoiu <mihai.patrascoiu@xxxxxxx> --- Hello, Please find below the output of the review. I've flagged the following two items for more attention: [?]: Package contains no static executables. [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in oidc- agent-cli , oidc-agent-desktop , oidc-agent-libs , oidc-agent-devel Other than that, everything else looks good! Cheers, Mihai Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [?]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "GNU Lesser General Public License v2.1 or later", "ISC License", "*No copyright* ISC License", "BSD 2-Clause License". 536 files have unknown license. Detailed output of licensecheck in /2221992-oidc- agent/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in oidc- agent-cli , oidc-agent-desktop , oidc-agent-libs , oidc-agent-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: oidc-agent-cli-4.5.2-1.fc38.x86_64.rpm oidc-agent-desktop-4.5.2-1.fc38.x86_64.rpm oidc-agent-libs-4.5.2-1.fc38.x86_64.rpm oidc-agent-devel-4.5.2-1.fc38.x86_64.rpm oidc-agent-debuginfo-4.5.2-1.fc38.x86_64.rpm oidc-agent-debugsource-4.5.2-1.fc38.x86_64.rpm oidc-agent-4.5.2-1.fc38.src.rpm ========================================= rpmlint session starts ======================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpaxlrx_v6')] checks: 31, packages: 7 oidc-agent.spec:92: W: unversioned-explicit-provides bundled(cjson) oidc-agent.spec:93: W: unversioned-explicit-provides bundles(clibs-list) oidc-agent-devel.x86_64: W: no-documentation oidc-agent-desktop.x86_64: W: desktopfile-without-binary /usr/share/applications/oidc-gen.desktop sh ========== 7 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 1.5 s ========= Rpmlint (debuginfo) ------------------- Checking: oidc-agent-libs-debuginfo-4.5.2-1.fc38.x86_64.rpm oidc-agent-cli-debuginfo-4.5.2-1.fc38.x86_64.rpm oidc-agent-desktop-debuginfo-4.5.2-1.fc38.x86_64.rpm oidc-agent-debuginfo-4.5.2-1.fc38.x86_64.rpm ========================================= rpmlint session starts ======================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6aofd1xi')] checks: 31, packages: 4 ========== 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.8 s ========= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 9 oidc-agent-cli.x86_64: W: unused-direct-shlib-dependency /usr/bin/oidc-gen /lib64/libmicrohttpd.so.12 oidc-agent-libs.x86_64: E: unused-direct-shlib-dependency /usr/lib64/liboidc-agent.so.4.5.2 /lib64/libclibs_list.so.0 oidc-agent-devel.x86_64: W: no-documentation 9 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 1.7 s Source checksums ---------------- https://github.com/indigo-dc/oidc-agent/archive/refs/tags/v4.5.2/oidc-agent-4.5.2.tar.gz : CHECKSUM(SHA256) this package : cfb0e3250485682551ab86744ab8b79b5d18149c12d36c95fa3d80ab16d68e69 CHECKSUM(SHA256) upstream package : cfb0e3250485682551ab86744ab8b79b5d18149c12d36c95fa3d80ab16d68e69 Requires -------- oidc-agent-cli (rpmlib, GLIBC filtered): /usr/bin/bash config(oidc-agent-cli) libc.so.6()(64bit) libcjson.so.1()(64bit) libclibs_list.so.0()(64bit) libcurl.so.4()(64bit) libglib-2.0.so.0()(64bit) libmicrohttpd.so.12()(64bit) liboidc-agent.so.4()(64bit) libqrencode.so.4()(64bit) libsecret-1.so.0()(64bit) libsodium.so.23()(64bit) oidc-agent-libs(x86-64) rtld(GNU_HASH) oidc-agent-desktop (rpmlib, GLIBC filtered): config(oidc-agent-desktop) libc.so.6()(64bit) libcjson.so.1()(64bit) libclibs_list.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libjavascriptcoregtk-4.0.so.18()(64bit) libsodium.so.23()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libwebkit2gtk-4.0.so.37()(64bit) oidc-agent-cli oidc-agent-libs(x86-64) rtld(GNU_HASH) oidc-agent-libs (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcjson.so.1()(64bit) libclibs_list.so.0()(64bit) libsodium.so.23()(64bit) rtld(GNU_HASH) oidc-agent-devel (rpmlib, GLIBC filtered): liboidc-agent.so.4()(64bit) oidc-agent-libs(x86-64) oidc-agent-debuginfo (rpmlib, GLIBC filtered): oidc-agent-debugsource (rpmlib, GLIBC filtered): Provides -------- oidc-agent-cli: config(oidc-agent-cli) oidc-agent-cli oidc-agent-cli(x86-64) oidc-agent-desktop: application() application(oidc-gen.desktop) config(oidc-agent-desktop) mimehandler(x-scheme-handler/edu.kit.data.oidc-agent) oidc-agent oidc-agent-desktop oidc-agent-desktop(x86-64) oidc-agent-libs: liboidc-agent.so.4()(64bit) liboidc-agent4 oidc-agent-libs oidc-agent-libs(x86-64) oidc-agent-devel: oidc-agent-devel oidc-agent-devel(x86-64) oidc-agent-debuginfo: oidc-agent-debuginfo oidc-agent-debuginfo(x86-64) oidc-agent-debugsource: oidc-agent-debugsource oidc-agent-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --bug 2221992 --mock-config fedora-38-x86_64 Buildroot used: fedora-38-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Java, fonts, SugarActivity, Perl, Haskell, R, Python, Ocaml, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2221992 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202221992%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
