https://bugzilla.redhat.com/show_bug.cgi?id=2223432 --- Comment #2 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- (In reply to Miro Hrončok from comment #1) > General comments on the spec, opiniuonated: > > > %global srcname merge3 > > Please don't define this macro. It makes the spec file harder to read. > Expand it in the spec instead. I guess this is the opinionated part ;-) ? But ... I'm on the fence, so yes, applied, thanks. > > %if 0%{?fedora} > > %bcond_without attest > > %else > > # some attestation dependencies not in EPEL > > %bcond_with attest > > %endif > > Consider this instead: > > # some testing dependencies not in EPEL > %bcond attest 0%{?fedora} > Ah, this was inherited from a previous spec, I forgot to remove it. Sorry. But quick observation, I thought %bcond does not work yet in EL 9 and below > > Patch: %{srcname}-verbose-testlog.diff > > Please document the reason for this in the spec. > Good point, thanks. > > > # BuildRequires: python3dist(pytest) > > Why is this commented out? If it's not needed, please drop it entirely. > >From previous spec, I wanted to make sure the tests run first then forgot to remove > > > %license COPYING > > I haven't attempted a build yet but this might be duplicated. The wheel > contains: > > License-File: COPYING > License-File: AUTHORS Ah, I just checked with rpm -qpL on an updated local build and this indeed gets done automatically now, nice. Removed the %license declaration and added a comment to note. Thank you Miro! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2223432 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202223432%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
