https://bugzilla.redhat.com/show_bug.cgi?id=2223432 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- General comments on the spec, opiniuonated: > %global srcname merge3 Please don't define this macro. It makes the spec file harder to read. Expand it in the spec instead. > %if 0%{?fedora} > %bcond_without attest > %else > # some attestation dependencies not in EPEL > %bcond_with attest > %endif Consider this instead: # some testing dependencies not in EPEL %bcond attest 0%{?fedora} it is simpler to write and simpler to read. > Patch: %{srcname}-verbose-testlog.diff Please document the reason for this in the spec. > # BuildRequires: python3dist(pytest) Why is this commented out? If it's not needed, please drop it entirely. > %license COPYING I haven't attempted a build yet but this might be duplicated. The wheel contains: License-File: COPYING License-File: AUTHORS -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2223432 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202223432%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
