[Bug 1877006] Review Request: smf-spf - Mail filter for Sender Policy Framework verification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1877006



--- Comment #46 from Jordi Sanfeliu <jordi@xxxxxxxxxxxx> ---
(In reply to Petr Pisar from comment #45)
> TODO: Are you sure sendmail is required at build time (smf-spf.spec:23)?

No, it doesn't. It was a mistake.
Fixed.


> FIX: Correct a version in the changelog entry. It must be
> '2.5.1^20220423g061e937-1'.

OK, done.


> FIX: Add a tmpfiles configuration file for /run/smfs directory. You mention
> it in a comment at smf-spf.spec:52, but probably forget to install it.

I think I've fixed it.


> FIX: The sysuser approach does not work for me. %pre script is empty as
> rpmlint warns and indeed after installing the package there is no smfs user
> and /run/smfs is owner by root. Also starting the service "fails" like this:
> Jul 12 10:44:59 fedora-39 systemd[1]: Starting smf-spf.service - Sender
> Policy Framework milter...
> Jul 12 10:44:59 fedora-39 smf-spf[3080]: starting smf-spf 2.5.2 listening on
> unix:/run/smfs/smf-spf.sock
> Jul 12 10:44:59 fedora-39 smf-spf[3080]: getpwnam smfs: User does not exists
> Jul 12 10:44:59 fedora-39 systemd[1]: smf-spf.service: Deactivated
> successfully.
> Jul 12 10:44:59 fedora-39 systemd[1]: Started smf-spf.service - Sender
> Policy Framework milter.
> 
> If sysuser approach does not work, we should use manual scrips with useradd
> command.

I think I've fixed it.
Let's see how it goes this time.


- Please, find the latest .spec and SRPM versions here
Spec URL: https://ftp.fibranet.cat/smf-spf/smf-spf.spec
SRPM URL:
https://ftp.fibranet.cat/smf-spf/smf-spf-2.5.1^20220423g061e937-1.fc38.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1877006

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201877006%23c46
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux