https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #45 from Petr Pisar <ppisar@xxxxxxxxxx> --- Url and Source0 addresses are Ok. Source0 archive (SHA-512: 5b7955dae6d19bea1290e2cfd700d150ad46e53325b5bac9305f6534623802daecd8aee0696cb47708934e2a8b8008a8536f0d65657cf1003a12a1423bfb4a3e) is original. Ok. License verified from smf-spf.c, COPYING, .devcontainer/Dockerfile. Ok. TODO: Are you sure sendmail is required at build time (smf-spf.spec:23)? $ rpmlint smf-spf.spec ../SRPMS/smf-spf-2.5.1^20220423g061e937-1.fc39.src.rpm ../RPMS/x86_64/smf-spf-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 5 smf-spf.x86_64: W: non-standard-uid /run/smfs smfs smf-spf.x86_64: W: non-standard-gid /run/smfs smfs smf-spf.x86_64: E: non-standard-dir-perm /run/smfs 700 smf-spf.x86_64: W: no-manual-page-for-binary smf-spf smf-spf.spec:54: W: macro-in-comment %{SOURCE4} smf-spf.spec:54: W: macro-in-comment %{buildroot} smf-spf.spec:54: W: macro-in-comment %{_sysusersdir} smf-spf.spec:54: W: macro-in-comment %{SOURCE4} smf-spf.spec:54: W: macro-in-comment %{buildroot} smf-spf.spec:54: W: macro-in-comment %{_sysusersdir} smf-spf.x86_64: W: incoherent-version-in-changelog 2.5.1-1 ['2.5.1^20220423g061e937-1.fc39', '2.5.1^20220423g061e937-1'] smf-spf.x86_64: E: file-parent-ownership-mismatch Path "/run/smfs/smf-spf.sock" owned by "root" is stored in directory owned by "smfs" smf-spf.x86_64: W: empty-%pre ======== 4 packages and 1 specfiles checked; 2 errors, 11 warnings, 2 badness; has taken 0.3 s ======== FIX: Correct a version in the changelog entry. It must be '2.5.1^20220423g061e937-1'. FIX: Add a tmpfiles configuration file for /run/smfs directory. You mention it in a comment at smf-spf.spec:52, but probably forget to install it. FIX: The sysuser approach does not work for me. %pre script is empty as rpmlint warns and indeed after installing the package there is no smfs user and /run/smfs is owner by root. Also starting the service "fails" like this: Jul 12 10:44:59 fedora-39 systemd[1]: Starting smf-spf.service - Sender Policy Framework milter... Jul 12 10:44:59 fedora-39 smf-spf[3080]: starting smf-spf 2.5.2 listening on unix:/run/smfs/smf-spf.sock Jul 12 10:44:59 fedora-39 smf-spf[3080]: getpwnam smfs: User does not exists Jul 12 10:44:59 fedora-39 systemd[1]: smf-spf.service: Deactivated successfully. Jul 12 10:44:59 fedora-39 systemd[1]: Started smf-spf.service - Sender Policy Framework milter. If sysuser approach does not work, we should use manual scrips with useradd command. The package builds in F39 (https://koji.fedoraproject.org/koji/taskinfo?taskID=103259442). Ok. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1877006 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201877006%23c45 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
