https://bugzilla.redhat.com/show_bug.cgi?id=2085444 --- Comment #63 from Cole Robinson <crobinso@xxxxxxxxxx> --- The source package can be named sgxsdk but I think the main binary package should be sgxsdk-devel. That's the naming used in similar cases when the package only ships dev content and not any shared libraries. examples: header only c++ libraries, rust crates `-samples` package naming is not common in Fedora, there's many more instances of `-examples`. And typically example code goes into /usr/share/doc with `%doc` There's also a compiled .so file sneaking in there: sgxsdk-samples.x86_64: E: arch-dependent-file-in-usr-share /usr/share/sgxsdk/SampleCode/RemoteAttestation/sample_libcrypto/libsample_libcrypto.so which seems strange since this is essentially documentation. Maybe `%exclude` it in %files or delete it after %make_install I understand libraries need to be bundled. Fedora packaging guidelines say they should be documented in that case, with Provides: lines in the spec file. See this section: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling Here's a couple starting points: Provides: bundled(protobuf) = 3.20.1 Provides: bundled(tinyxml) = 7.0.0 Here's some small changes: typo fix, trailing whitespace, use %autosetup: --- srpm/sgxsdk.spec 2023-07-01 12:28:20.001294623 -0400 +++ srpm-unpacked/sgxsdk.spec 2023-07-01 14:26:31.008591969 -0400 @@ -1,4 +1,4 @@ -# SGX SDK is for development use only hence no deubg package needed. +# SGX SDK is for development use only hence no debug package needed. %define debug_package %{nil} Name: sgxsdk @@ -43,8 +43,8 @@ BuildRequires: nasm ExclusiveArch: x86_64 %description -The Intel SGX SDK is a collection of APIs, libraries, documentation, and tools -that allows software developers to create and debug Intel SGX enabled +The Intel SGX SDK is a collection of APIs, libraries, documentation, and tools +that allows software developers to create and debug Intel SGX enabled applications in C/C++. %package -n sgxsdk-samples @@ -54,12 +54,12 @@ Requires: libsgx-urts >= %{version Requires: libsgx-enclave-common >= %{version}-%{release} %description -n sgxsdk-samples -The Intel SGX SDK sample code projects show developers how to create an +The Intel SGX SDK sample code projects show developers how to create an enclave, how to use C++11 library inside the enclave, how to do local attestation and remote attestation, etc. %prep -%setup -qc +%autosetup -c %build %make_build -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2085444 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202085444%23c63 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
