[Bug 2085444] Review Request: sgx-sdk - Software Guard eXtension software development kit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2085444



--- Comment #62 from Cestmir Kalina <ckalina@xxxxxxxxxx> ---
(In reply to xiangquan.liu from comment #60)
> (In reply to Cestmir Kalina from comment #58)
> > FWIW, although it's probably a small detail: the sample codes packaged in
> > the subpackage sgxsdk-samples cannot be built: sgx_edger8r installed by this
> > package cannot be located, as the sample code Makefiles try to locate it in
> > one of the following (depending on setup):
> > ${SGX_SDK:-/opt/intel/sgxsdk}/bin/{x86,x64}/. I think those are the original
> > paths before it was moved out of /opt.
> 
> Could you please review SampleEnclave which I modified its Makefile already?
> I think SampleEnclave can be built successfully.

I pulled the latest SRPM and I am afraid that the issue persists, even in
SampleEnclave, on a fresh Fedora rawhide install (with sgxsdk-samples
dependencies manually compiled and installed so that $(SGX_SDK) default is not
present).

# relevant snippets of: SampleCode/SampleEnclave/Makefile
34  SGX_SDK ?= /opt/intel/sgxsdk
..
51  ifeq ($(SGX_ARCH), x86)
..
55      SGX_EDGER8R := $(SGX_SDK)/bin/x86/sgx_edger8r
56  else
..
60      SGX_EDGER8R := $(SGX_SDK)/bin/x64/sgx_edger8r
61  endif
..
63  # For onespec, tools like sgx_sign are moved to /usr/bin
..
68  ifeq ($(wildcard $(SGX_EDGER8R)),)
69      SGX_EDGER8R := sgx_edger8r
70  endif
..
233 App/Enclave_u.h: $(SGX_EDGER8R) Enclave/Enclave.edl

$ make # hw mode, debug build, no mitigation, per instructions in README.txt
make[1]: Entering directory '/buildtmpfs/SampleCode/SampleEnclave'
make[1]: *** No rule to make target 'sgx_edger8r', needed by 'App/Enclave_u.h'.
 Stop.

Changing line 69 to something like SGX_EDGER8R := $(shell command -v
sgx_edger8r) instead does allow the compilation to proceed.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2085444

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202085444%23c62
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux