https://bugzilla.redhat.com/show_bug.cgi?id=2190490 Link Dupont <link@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Link Dupont <link@xxxxxxxxxxx> --- A few small commits have been released since 1.4.9; consider bumping the version to 1.4.10. https://github.com/hashicorp/go-plugin/compare/v1.4.9...v1.4.10 Some .gitignore files are included in the package via %godocs including examples. Consider removing them during %prep. > golang-github-hashicorp-plugin-devel.noarch: E: version-control-internal-file /usr/share/doc/golang-github-hashicorp-plugin-devel/examples/basic/.gitignore > golang-github-hashicorp-plugin-devel.noarch: E: version-control-internal-file /usr/share/doc/golang-github-hashicorp-plugin-devel/examples/grpc/.gitignore > golang-github-hashicorp-plugin-devel.noarch: E: version-control-internal-file /usr/share/doc/golang-github-hashicorp-plugin-devel/examples/negotiated/.gitignore %prep %goprep %autopatch -p1 find . -iname .gitignore -exec rm {} \; Approving the package, but consider them before/during import. - [x] The spec file is clear and easy to read - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No rpmlint errors (or valid justification for exceptions) - [x] %check section passes - [x] The latest version is packaged - [x] %goipath is set correctly - [x] The package complies with the Packaging Guidelines On import, don't forget to do the following: - [ ] Add package to https://release-monitoring.org - [ ] Add package to https://koschei.fedoraproject.org/packages - [ ] Grant @go-sig group commit privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2190490 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202190490%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
