[Bug 2218703] Review Request: python-perky - A simple, Pythonic file format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2218703



--- Comment #4 from Maxwell G <maxwell@xxxxxxx> ---
> Comments:
> a) Please check with upstream on intended license, pypi indicates BSD
> https://pypi.org/project/perky/
> though license file in the repository is MIT.

https://github.com/larryhastings/perky/pull/14

> b) Please also check if
> https://github.com/larryhastings/perky/blob/master/perky/transform.py#L1-L14
> will impact packaging.

I don't see how that would affect packaging.

> c) Add an explanation for why
> sed -i -e '1{\@^#!.*@d}' perky/utility.py
> is needed in the spec file.

Added a specfile comment.

> d) Can likely remove
> %license LICENSE
> as license is packaged in
> usr/lib/python3.11/site-packages/perky-0.8.1.dist-info/

Added a specfile comment.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2218703

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218703%23c4
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux