https://bugzilla.redhat.com/show_bug.cgi?id=2217257 --- Comment #4 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to leigh scott from comment #1) > A: you don't gzip man files, rpmbuild does it. > > gzip %{buildroot}/%{_mandir}/man1/*.1 > gzip %{buildroot}/%{_mandir}/man5/*.5 Oh, I didn't know. I haven't had to deal with man pages often. > B: You don't include the .gz extension in files. > > > %doc %{_mandir}/man1/*.1.gz > %doc %{_mandir}/man5/*.5.gz Right. Although it doesn't hurt either (see C). > C: man pages aren't considered docs or have the packaging guidelines changed > recently? > > %doc %{_mandir}/man1/*.1.gz > %doc %{_mandir}/man5/*.5.gz They are. The link you posted in comment #2 states: "Note also that files installed in %{_mandir} are automatically marked by RPM as documentation. Thus it is not necessary to use %doc." You can also see that by, e.g., looking at git with 'rpm -qd git'. It will list installed manpages. So, while '%doc' is not needed, it doesn't hurt either. I've done A and B in another package before and rpmlint didn't complain. Not sure if that was before or after package review. Anyway, I'll change it. (In reply to Remi Collet from comment #3) > Minor: according to https://github.com/nih-at/nihtest/blob/main/README.md > nihtest-case.1 should be nihtest-case.5 You are correct. Oversight on my part. 'mandoc -l nihtest-case.man' also shows it should be nihtest-case.5. I will correct that. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2217257 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202217257%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
