https://bugzilla.redhat.com/show_bug.cgi?id=2217097 --- Comment #8 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> --- So I spent a bit of time reverse engineering how the SOVERSION works. They use the git tag to store the soversion and it's a bit buggy, so I need to talk to upstream about how to fix it. For the time being, I made a patch to allow setting the string via CMake variable, so that should be better for Fedora in the long run, as I assume we don't want to deal with git tags. I just need to confirm what value it actually should be. Upstream packages have "5.0.0" in the ROCm 5.5.1 packages for some reason, even though the tag on github is 5.5.1. If it's supposed to be "5.5.1", I'll send my patches upstream and notify them of the bug. If it's supposed to be "5.0.0", then I'm going to ask upstream if they can maintain and update the cmake default value to the correct value instead of my patch. Anyway, here's the latest: Spec URL: https://mystro256.fedorapeople.org/rocm-smi.spec SRPM URL: https://mystro256.fedorapeople.org/rocm-smi-5.5.1-2.fc39.src.rpm COPR: https://copr.fedorainfracloud.org/coprs/mystro256/rocm-hip/build/6112127/ We can resume once I figure out the version string situation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2217097 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202217097%23c8 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
