https://bugzilla.redhat.com/show_bug.cgi?id=2214063 Alisson Bruno <alissonbruno.sa@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(gwync@protonmail. | |com) --- Comment #2 from Alisson Bruno <alissonbruno.sa@xxxxxxxxx> --- Hi @gwync@xxxxxxxxxxxxxx, Thank you for your review. SPEC: https://github.com/alissonbrunosa/xorg-x11-xdm/blob/main/xorg-x11-xdm.spec SRPMs: - [Fedora 37](https://download.copr.fedorainfracloud.org/results/alissonbruno/xorg-x11-xdm/fedora-37-x86_64/06072750-xorg-x11-xdm/xorg-x11-xdm-1.1.14-29.fc37.src.rpm) - [Fedora 38](https://download.copr.fedorainfracloud.org/results/alissonbruno/xorg-x11-xdm/fedora-38-x86_64/06072750-xorg-x11-xdm/xorg-x11-xdm-1.1.14-29.fc38.src.rpm) - [EPEL 7](https://download.copr.fedorainfracloud.org/results/alissonbruno/xorg-x11-xdm/epel-7-x86_64/06072750-xorg-x11-xdm/xorg-x11-xdm-1.1.14-29.el7.src.rpm) - [EPEL 8](https://download.copr.fedorainfracloud.org/results/alissonbruno/xorg-x11-xdm/epel-8-x86_64/06072750-xorg-x11-xdm/xorg-x11-xdm-1.1.14-29.el8.src.rpm) - [EPEL 9](https://download.copr.fedorainfracloud.org/results/alissonbruno/xorg-x11-xdm/epel-9-x86_64/06072750-xorg-x11-xdm/xorg-x11-xdm-1.1.14-29.el9.src.rpm) I've fixed most of the rpmlint issue. The only ones left are: xorg-x11-xdm.x86_64: W: empty-%postun xdm depends on xorg-x11-xinit, which provides the linked file xorg-x11-xdm.x86_64: W: dangling-relative-symlink /etc/X11/xdm/Xsession ../xinit/Xsession Can't really do anything here, the xdm binary uses gethostbyname, to fix it I would have to fix it in the source. xorg-x11-xdm.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/xdm xorg-x11-xdm.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/libexec/chooser [OK] package meets naming guidelines [OK] package meets packaging guidelines [FIXED] license (MIT) OK, text in %doc, matches source. Move COPYING from %doc to %license [OK] spec file legible, in am. english [OK] source matches upstream [OK] package compiles on devel (x86) [OK] no missing BR [OK] no unnecessary BR [OK] no locales [OK] not relocatable [OK] owns all directories that it creates [OK] no duplicate files [OK] permissions ok [OK] %clean ok [OK] macro use consistent [OK] code, not content [OK] no need for -docs [OK] nothing in %doc affects runtime [OK] no need for .desktop file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2214063 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202214063%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
