[Bug 2214063] Review Request: xorg-x11-xdm - Unretire package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2214063



--- Comment #1 from Gwyn Ciesla <gwync@xxxxxxxxxxxxxx> ---
- rpmlint checks return:

xorg-x11-xdm.x86_64: E: incorrect-fsf-address /etc/X11/xdm/Xsetup_0
xorg-x11-xdm.x86_64: E: executable-marked-as-config-file /etc/X11/xdm/Xreset
xorg-x11-xdm.x86_64: E: executable-marked-as-config-file /etc/X11/xdm/Xsetup_0
xorg-x11-xdm.x86_64: E: executable-marked-as-config-file /etc/X11/xdm/Xstartup
xorg-x11-xdm.x86_64: E: executable-marked-as-config-file /etc/X11/xdm/Xwilling
xorg-x11-xdm.x86_64: W: empty-%postun
xorg-x11-xdm.x86_64: W: dangling-relative-symlink /etc/X11/xdm/Xsession
../xinit/Xsession
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xaccess
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xreset
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xresources
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xservers
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xsetup_0
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xstartup
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xwilling
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/xdm-config
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/pam.d/xdm
xorg-x11-xdm.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/xdm
xorg-x11-xdm.x86_64: W: binary-or-shlib-calls-gethostbyname
/usr/libexec/chooser

If memory serves these are all OK but make sure.

+ package meets naming guidelines
+ package meets packaging guidelines
- license (MIT) OK, text in %doc, matches source
   Move COPYING from %doc to %license
+ spec file legible, in am. english
+ source matches upstream
+ package compiles on devel (x86)
+ no missing BR
+ no unnecessary BR
+ no locales
+ not relocatable
+ owns all directories that it creates
+ no duplicate files
+ permissions ok
+ %clean ok
+ macro use consistent
+ code, not content
+ no need for -docs
+ nothing in %doc affects runtime
+ no need for .desktop file


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2214063

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202214063%23c1
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux