https://bugzilla.redhat.com/show_bug.cgi?id=2212222 --- Comment #2 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #1) > Some minor issues: > > 1. The upstream license seems to be GPL-3.0-or-later, not GPL-3.0-only (see > help text output at the bottom of "src/greeter.rs") - yes, it would be good > if upstream had this in the Cargo.toml metadata (i.e. [package] license = > "GPL-3.0-or-later"). https://github.com/apognu/tuigreet/commit/2832dac71f1f7faca6b7c94e10f5f8bf7f1f2819 made me believe that it uses the same license as greetd (which is GPL-3.0-only as confirmed by the greetd upstream). GPL-3.0 from Cargo metadata is also a deprecated identifier for GPL-3.0-only. And upstream developer's own packages on AUR list the license as GPL3. I'm going to assume -only for this review and file an issue with clarification request. > 2. Why is the version of the tarball 0.8.0 but the one in the Cargo metadata > is 0.7.3? Did upstream tag a new version without bumping the version in > metadata? Yes, that's exactly what happened. Easy to miss when you don't publish to crates.io. > There is no rationale for the patch other than "fix crate version". It fixes `tuigreet --version` output. No other reason :( > 3. Remove "ExclusiveArch: %{rust_arches}". It is a noop that is no longer > needed, and it is no longer mandated by the Packaging Guidelines. Thanks for catching, will fix. This spec was made long time ago, seems like I failed to update everything according to the current guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2212222 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202212222%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
