https://bugzilla.redhat.com/show_bug.cgi?id=2212222 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED CC| |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Some minor issues: 1. The upstream license seems to be GPL-3.0-or-later, not GPL-3.0-only (see help text output at the bottom of "src/greeter.rs") - yes, it would be good if upstream had this in the Cargo.toml metadata (i.e. [package] license = "GPL-3.0-or-later"). 2. Why is the version of the tarball 0.8.0 but the one in the Cargo metadata is 0.7.3? Did upstream tag a new version without bumping the version in metadata? There is no rationale for the patch other than "fix crate version". 3. Remove "ExclusiveArch: %{rust_arches}". It is a noop that is no longer needed, and it is no longer mandated by the Packaging Guidelines. Other than that, package looks good. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2212222 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202212222%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
