https://bugzilla.redhat.com/show_bug.cgi?id=2213372 --- Comment #1 from Tom Rix <trix@xxxxxxxxxx> --- I think it is good to prepare for the deprecation of hipcc.pl. I understand the need for hipcc.bin and hipconfig.bin but the extension is confusing It would be best if hipcc and hipp.pl could go away and hipcc.bin became hipcc calling hipcc.bin and hipconfig.bin directly both failed. could this wait until the deprecation of hipcc.pl is completed upstream ? Some other notes below -Source0: https://github.com/ROCm-Developer-Tools/HIPCC/archive/refs/tags/rocm-%{version}.tar.gz#/%{name}-%{version}.tar.gz +# use %{url} to reduce generally all these instances that have it as a prefix +#Source0: https://github.com/ROCm-Developer-Tools/HIPCC/archive/refs/tags/rocm-%{version}.tar.gz#/%{name}-%{version}.tar.gz +Source0: %{url}/HIPCC/archive/refs/tags/rocm-%{version}.tar.gz#/%{name}-%{version}.tar.gz #Upstream fixes: # HIPCC is very new, so cmake was incomplete when 5.5 was tagged: @@ -31,6 +33,8 @@ Requires: hip >= %{version} Requires: clang # 16.2 has an important fix for hipcc to work out of the box: Requires: rocm-device-libs >= 16.2 +# battling hipcc vs hipcc.bin +# Conflicts: hip <= 5.5.1 # This package depends on "hip" which is only built on these arches right now: ExclusiveArch: x86_64 aarch64 ppc64le @@ -51,12 +55,25 @@ must ensure the compiler options are appropriate for the target compiler. sed -i '/" -isystem " + hsaPath + "\/include"/d' src/hipBin_amd.h %build -%cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo +# Should just use %cmake, and let rpm macros determine the build type +# %cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo +%cmake %cmake_build %install %cmake_install +# Needs a %check +# > hipcc.bin +# sh: line 1: /tmp/canRunUUdQtd: Is a directory +# sh: line 1: /tmp/canRuntxtm5v: Is a directory +# sh: line 1: /tmp/canRunJMKATa: Is a directory +# sh: line 1: /tmp/canRunhWTbpf: Is a directory +# Device not supported - Defaulting to AMD +# No Arguments passed, exiting ... +# +# Similar for hipconfig.bin + -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2213372 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202213372%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
