https://bugzilla.redhat.com/show_bug.cgi?id=2193400 Lokesh Mandvekar <lsm5@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(pingou@pingoured. | |fr) CC| |pingou@xxxxxxxxxxxx --- Comment #25 from Lokesh Mandvekar <lsm5@xxxxxxxxxx> --- (In reply to Carl George 🤠 from comment #24) > I'll point out that the solution in https://github.com/containers/qm/pull/62 > (which obsoletes https://github.com/containers/qm/pull/59) does not follow > the packaging guidelines. > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_dependency_types > > > Requires MUST be used if the dependency is required for the software to function correctly. > > You can't just skip the dependency when it's not available, if it's truly a > dependency. If it's not truly a dependency, then using a Recommends is > probably a better choice. @pingou@xxxxxxxxxxxx PTAL, wdyt ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2193400 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
