[Bug 2121902] Review Request: pyinstrument - Python profiler with colorful output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2121902



--- Comment #14 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
(In reply to Alexander Ploumistos from comment #13)
> Something has glitched here, because rpmlint spews a new warning:
> pyinstrument.x86_64: W: incoherent-version-in-changelog 4.4.0-2
> ['4.4.0-3.fc39', '4.4.0-3']

I used '[skip changelog]' in the commit (because it only affects the spec
file),
and doesn't need to be described in %changelog. But this means that the
generated
spec file has the release field bumped without a changelog entry (the last
changelog entry is 4.4.0-2, but the srpm has version 4.4.0-3).

Basically, with rpmautospec, if there is no changelog entry for a rebuild,
the user has to assume that there is no user-visible change since the last
entry
in the changelog. The same is actually true with a manual changelog, except
that there the maintainer might have simply forgotten to do a changelog
entry.

In principle, we could try to implement some solution for this, but I think
that this matters very little for users and we can ignore the problem.

OTOH, fedora-review and rpmlint should understand that %autochangelog is
used (there's a tag at the top of the spec file:
 ## RPMAUTOSPEC: autorelease, autochangelog
) and completely ignore the generated changelog.

> The package is approved.

Thanks!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2121902
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux