[Bug 2121902] Review Request: pyinstrument - Python profiler with colorful output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2121902

Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #13 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> ---
Thank you for all the replies Zbigniew, it's been very educational.


(In reply to Zbigniew Jędrzejewski-Szmek from comment #10)
> (In reply to Alexander Ploumistos from comment #9)
> > Unversioned so-files
> > pyinstrument: /usr/lib64/python3.11/site-packages/pyinstrument/low_level/stat_profile.cpython-311-x86_64-linux-gnu.so
> 
> You didn't mention this one, but it is another similar case: rpmlint could
> check
> that this path is not in the shared library search path, and avoid the
> useless warning.
> Or it could even hardcode that anything with /site-packages/ can be ignored.
> Instead,
> we emit this warning for a large subset of the ~10k python packages.

I didn't mention it, because I had already checked myself (as required):
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.


> Updated. The only change is the license breakdown:
> Spec URL: https://in.waw.pl/~zbyszek/fedora/pyinstrument.spec
> SRPM URL: https://in.waw.pl/~zbyszek/fedora/pyinstrument-4.4.0-3.fc39.src.rpm


Something has glitched here, because rpmlint spews a new warning:
pyinstrument.x86_64: W: incoherent-version-in-changelog 4.4.0-2
['4.4.0-3.fc39', '4.4.0-3']

I trust you are more than capable of dealing with this - if indeed it needs to
be dealt with.


The package is approved.


P.S.: I'll try to advance with input-remapper on Thursday, though realistically
it's probably going to be the weekend, work has drained both my time and my
brain.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2121902
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux