https://bugzilla.redhat.com/show_bug.cgi?id=2121902 --- Comment #8 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Alexander Ploumistos from comment #7) > There's an app.js file under > %{python3_sitearch}/pyinstrument/renderers/html_resources/, which apparently > comes from Vue.js and it's MIT-licensed. I added MIT to the license line. spec/srpm updated in place. > I checked the contents of the cache of ldconfig (ldconfig -p) after > installation and I didn't see the packaged .so file > (stat_profile.cpython-311-x86_64-linux-gnu.so), so I guess that's not an > issue. Yes, this is just a normal python compiled module and it is never loaded via the dynamic linker. > fedora-review complains about the linked spec file and the one in the source > rpm not being the same. I use %autorelease and %autochangelog, and the spec file in the srpm is after processing. fedora-review should learn to ignore this. (Or maybe it already has, but this hasn't been released yet? I lost track.) > There's also this from fedora-review > [!]: Uses parallel make %{?_smp_mflags} macro. > but I don't see why that should be in this spec file. The build doesn't use make ;) > Finally, I find this part of the review template a bit confusing: > [ ]: A package which is used by another package via an egg interface should > provide egg info. > Is the provided *.dist-info directory an equivalent for the older > *.egg-info? Would this item on the list be explicitly required if > pyinstrument was being packaged as a dependency of another (Python) package? .egg-info is the older style of metadata. %pyproject and the new Python packaging standards use .dist-info. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121902 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
