https://bugzilla.redhat.com/show_bug.cgi?id=2121902 --- Comment #7 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> --- Hi Zbigniew, thanks for looking at input-remapper. The day went nothing like planned, so I didn't get to all the items on the checklist, here are some first comments. The package works great so far, kudos for digging it up! There's an app.js file under %{python3_sitearch}/pyinstrument/renderers/html_resources/, which apparently comes from Vue.js and it's MIT-licensed. You'll need to add that to your licenses. That being said, I wasn't able to find the same file in upstream Vue.js (https://github.com/vuejs), however the comment in the file is clear about that. I checked the contents of the cache of ldconfig (ldconfig -p) after installation and I didn't see the packaged .so file (stat_profile.cpython-311-x86_64-linux-gnu.so), so I guess that's not an issue. fedora-review complains about the linked spec file and the one in the source rpm not being the same. There's also this from fedora-review [!]: Uses parallel make %{?_smp_mflags} macro. but I don't see why that should be in this spec file. Finally, I find this part of the review template a bit confusing: [ ]: A package which is used by another package via an egg interface should provide egg info. Is the provided *.dist-info directory an equivalent for the older *.egg-info? Would this item on the list be explicitly required if pyinstrument was being packaged as a dependency of another (Python) package? I think/hope I can finish the review tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121902 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
